[SYCL] Reset in-mem cache in early shutdown #20948
Merged
+29
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
cperkinsintel
approved these changes
Dec 22, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a segmentation fault that occurs when kernel libraries deregister with the SYCL runtime in parallel after early shutdown. The fix ensures that the in-memory cache (containing device images, kernels, and programs) is cleared before releasing SYCL contexts during early shutdown, preventing attempts to release kernel/program resources after their associated contexts have already been released.
Key Changes:
- Clear in-memory cache during early shutdown before releasing default contexts
- Replace exception throwing with early return when cache entries aren't found (post-shutdown scenario)
- Update test expectations to reflect the new order of resource release operations
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| sycl/source/detail/global_handler.cpp | Adds logic to reset in-memory cache for all platform default contexts before releasing them during early shutdown |
| sycl/source/detail/kernel_program_cache.hpp | Changes cache clearing to use .clear() instead of reconstructing objects, and replaces exception with early return for missing cache entries |
| sycl/test-e2e/Scheduler/ReleaseResourcesTest.cpp | Updates test expectations to reflect that programs/kernels are now released before contexts |
| sycl/test-e2e/KernelAndProgram/disable-caching.cpp | Updates test expectations to reflect new release ordering during early shutdown |
| sycl/test-e2e/Basic/queue/release.cpp | Updates test expectations to reflect that kernels/programs are now released before contexts |
Contributor
|
@intel/llvm-gatekeepers please consider merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When a kernel library deregisters with the SYCL RT, we clear the associated device images and kernel/program entries from in-memory cache. When a library deregisters with the SYCL RT parallelly after early shutdown, releasing kernel/programs might segfault because we have already released all the context (urContextRelease) during early shutdown.
Solution
Clear up in-memory cache in early shutdown before releasing SYCL contexts.